filter out conversations with invalid topics #495
Merged
+76
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
3691bfc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3edfe0ce.xmtp-js.pages.dev |
| Branch Preview URL: | https://rygine-filter-invalid-topics.xmtp-js.pages.dev |
|
tests added |
neekolas
reviewed
Nov 29, 2023
| describe('topic utils', () => { | ||
| describe('isValidTopic', () => { | ||
| it('validates topics correctly', () => { | ||
| expect(isValidTopic(buildContentTopic('foo'))).toBe(true) |
There was a problem hiding this comment.
Appreciate the robust tests. It might be helpful to just generate a bunch of random topics (the way we do when creating invites) and ensure that those all pass as well.
There was a problem hiding this comment.
good callout!
added random topic tests here: test: add random topic testing
neekolas
approved these changes
Nov 29, 2023
rygine
force-pushed
the
rygine/filter-invalid-topics
branch
from
f3f94af to
01757fb
Compare
|
🎉 This PR is included in version 11.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.3.0-beta.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #491